-
Notifications
You must be signed in to change notification settings - Fork 109
Only pass full frames to opus encoder. Increase buffer size. #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Logic change looks good to me. How do we test and make sure that this doesn't cause major issues during rollout ? |
|
E2E passes, it specifically tests if audio conversion works as expected. I'll also test manually, just in case. This change won't be included in the current release until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to have @alexlivekit also give it a pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Don't know if we want to get defensive to the point of making sure w.SampleRate() / rtp.DefFramesPerSec results in an integer, but that's only a minor nitpick.
|
We are having problem with client audio on outbound calls. User speaks from his phone but agents can't hear. User can hear agents. But, we can hear both sides on PBX record. Do you think this PR can solve this problem? If its yes, when this PR gets to live? |
|
Could be related, yes. We've seen a few examples similar to what you described caused by this issue. As for the live deployment, we are currently working on another significant change that delays deployment of this one. We'll likely deploy it in ~2 weeks. |
|
Hello when @dennwc what is the ETA for a deployment? thanks! |
|
It will be fully deployed this week. |
|
Are we good to land this now? |
|
Would love to get this in by end of the week! |
Closes #465